search

mriscoc / Ender3V2S1

This is optimized firmware for Ender3 V2/S1 3D printers.
Other
2.62k stars 358 forks source link

[BUG] the lcd knob is going insane #977

Closed liamwerk7676 closed 1 year ago

liamwerk7676 commented 1 year ago

Did you test with a precompiled firmware?

Yes, and the problem still exists.

Bug Description

frimware makes lcd knob jump numbers foward and backwards before update worked fine now its all over the place

Bug Timeline

since updating

Expected behavior

lcd knob ups the number by 1

Actual behavior

randomly chooses a number

Steps to Reproduce

No response

Version of Professional Firmware

20230522

Printer model

ender 3v2

Electronics

Board 4.2.2

Add-ons

bltouch

Bed Leveling

UBL Bilinear mesh

Your Slicer

Cura

Host Software

SD Card (headless)

Additional information & file uploads

No response

mriscoc commented 1 year ago

It is not a firmware issue but a knob encoder issue, I have the same problem so I implemented a knob filtering in previous versions, but that filtering affects the speed for people with a good knob encoder. In the latest version I made the smooth optional by enabling or disabling it in the configuration file by using: https://github.com/mriscoc/Ender3V2S1/blob/73c11535a7c0de0044cfed0f564154a079be5782/Marlin/Configuration.h#L3365 If you want a smooth encoder operation you need to enable that line and custom compile your firmware version.

github-actions[bot] commented 1 year ago

This issue has had no activity in the last 60 days. Please add a reply if you want to keep this issue active, otherwise it will be automatically closed within 10 days.

github-actions[bot] commented 11 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.