mrjackphil / obsidian-text-expand

A simple text expand plugin for Obsidian.md
186 stars 12 forks source link

[BUG] Text expand is not working with Obsidian 0.13.14 #59

Closed andrezgz closed 2 years ago

andrezgz commented 2 years ago

Hello,

This is happening with several plugins nowadays, since Obsidian has been updated to CM6.

When I execute the "expand" command, the previous results are removed, the search is done with the parameters but the new results are not pasted into the editor.

Hope you get the time to fix it, since it's a great feature for Obsidian!

tumber43 commented 2 years ago

Much like andrezgz mentioned, with the last couple Obsidian versions, text expand produces a Null result. I updated to the latest Obsidian installer with a fresh download, and same result. I'm on Version 13.19. I tried disabling all other 3rd party plugins, same result... I tried using the Legacy Editor, same result. I haven't ruled out a cache issue since the legacy editor change.

imeed166 commented 2 years ago

+1 for this

Masktial commented 2 years ago

+1

tinainsz commented 2 years ago

+1

chen-bao-x commented 2 years ago

+1

mrjackphil commented 2 years ago

Just for you to know: fixing the plugin is on my list. Need to spend time figuring out how CM6 works and what changed.

Also, the most complex task is time management.

I changed my job from doing frontend. Now I do team management. Need some time to gain experience in new profession and regulate processes in the team.

And will have a second baby, soon.

I hope I will handle all excuses I have to bring working versions of my plugins.

andrezgz commented 2 years ago

I do understand your life/work pressures and priorities, @mrjackphil. You do this for pleasure and it doesn't pay your monthly bills, as you say.

The CM6 migration broke a lot of plugins and put maintainers in an awkward position. I've applied monkey patches on a few other plugins and shared them to build the definitive solution. I'll try to do the same with Text Expand.

andrezgz commented 2 years ago

Today, when I executed the "expand" command, it worked perfectly. The reason? The Search pane was in view. It seems that every time I tried in the past, it was hidden, the side-dock was expanded and collapsed quickly by the "expand" command and results were not pasted... (sometimes, results are pasted, but not all of them)

I immediately remembered reading something about "the search not running in background" in one of the Obsidian Release announcements (I check them thoroughly). Went to the forum and found it:

Improvements

  • Global search panes will no longer continuously run in the background when the pane is not in view.

So the mistery is solved. In order to bypass the issue, the Search pane must be in view before executing the "expand" command.

Don't know if there will be a definitive solution. Maybe forcing the Search pane to be in view (like pressing Ctrl+Shift+F does) when the "expand" command is executed?

x1101 commented 2 years ago

I'm also seeing this, and I'm not reliably getting CTRL+SHIFT+F to work. I've also enabled the vimrc plugin, which could be impacting it.

If I can provide any further info, let me know and I'll be happy to. Thank you for the work, this is a really excellent addon.

QuaCKeReD commented 2 years ago

Similar issue, still 😟

I found the search pane being open fixing the run of the search by mistake

But, when I run the expand, I now get an error under each file returned, stating that a section (that isnt detailed or requested), cannot be found in the the current file (which isnt in the path criteria and not returned by the search)

QuaCKeReD commented 2 years ago

which it seems is related to this;

CleanShot 20220317 120450 7MnYE3gR

The header link it is using is just a [[header]], not a [[file#header]]

QuaCKeReD commented 2 years ago

The above issue seems fixed in latest release 😀

mrjackphil commented 2 years ago

Nice. Feel free to reopen the issue if someone have more details on this.