Does not expand on mobile

derekvan commented 2 years ago

On iOS, this plugin does not appear to work. I have experimented with moving the delay shorter and longer but I haven’t been able to get an expansion to work.

zcysxy commented 2 years ago

Same bug

zcysxy commented 2 years ago

Hi @mrjackphil, after some experiments using BRAT and mobile emulation on a Mac, I found that

v0.9.0 works fine on mobile. but after this version, the command text expand: expand no longer writes the result.
v0.9.1 and v0.9.2 don't work, but they don't output any error.
Since v0.9.3, after executing text expnad: expand, an error occurs. The error log is attached.

Hi @derekvan, for now to make Text Expand work on mobile, you can use BRAT to install its frozen version of 0.9.0

plugin:mrj-text-expand:396 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'findIndex')
    at TextExpander.getSearchTabIndex (plugin:mrj-text-expand:396:25)
    at TextExpander.search (plugin:mrj-text-expand:375:23)
    at TextExpander.eval (plugin:mrj-text-expand:528:30)
    at step (plugin:mrj-text-expand:79:23)
    at Object.eval [as next] (plugin:mrj-text-expand:60:53)
    at eval (plugin:mrj-text-expand:53:71)
    at new Promise (<anonymous>)
    at __awaiter (plugin:mrj-text-expand:49:12)
    at TextExpander.runQuery (plugin:mrj-text-expand:516:16)
    at TextExpander.initExpander (plugin:mrj-text-expand:558:18)
TextExpander.getSearchTabIndex @ plugin:mrj-text-expand:396
TextExpander.search @ plugin:mrj-text-expand:375
eval @ plugin:mrj-text-expand:528
step @ plugin:mrj-text-expand:79
eval @ plugin:mrj-text-expand:60
eval @ plugin:mrj-text-expand:53
__awaiter @ plugin:mrj-text-expand:49
TextExpander.runQuery @ plugin:mrj-text-expand:516
TextExpander.initExpander @ plugin:mrj-text-expand:558
fH @ app.js:1
e.executeCommand @ app.js:1
e.executeCommandById @ app.js:1
eval @ plugin:obsidian-better-command-palette:15
eval @ plugin:obsidian-better-command-palette:15
e @ plugin:obsidian-better-command-palette:15
onChooseSuggestion @ plugin:obsidian-better-command-palette:15
eval @ plugin:obsidian-better-command-palette:15
eval @ plugin:obsidian-better-command-palette:15
e @ plugin:obsidian-better-command-palette:15
onChooseSuggestion @ plugin:obsidian-better-command-palette:15
t.selectSuggestion @ app.js:1
e.useSelectedItem @ app.js:1
(anonymous) @ app.js:1
e.handleKey @ app.js:1
e.onKeyEvent @ app.js:1

jedagon commented 1 year ago

@zcysxy, @mrjackphil

Tested on iPad. 0.9.0 works! Thanks!

mrjackphil / obsidian-text-expand

Does not expand on mobile #69