search

mrjackwills / adsbdb

public api for aircraft, airlines, & flightroutes
https://adsbdb.com
MIT License
139 stars 6 forks source link

[BUG] No example env files to test run #38

Open radumalica opened 1 month ago

radumalica commented 1 month ago

Describe the bug No example env files available to see what options can we use . Also, downloading the compiled release also requires an env file, exists with "Unable to load env file"

To Reproduce Steps to reproduce the behavior:

  1. clone the rpo
  2. execute ./run.sh as instructed in the README
  3. choose production up or dev up
  4. see error: 

production up: adsbdb_postgres adsbdb_redis adsbdb_api adsbdb_postgres_backup
added crontab "15 3 * * *  docker restart adsbdb_postgres_backup"? [y/N]: y
making directory: "/opt/workspaces/databases.d/adsbdb/pg_data"
making directory: "/opt/workspaces/databases.d/adsbdb/redis_data"
making directory: "/opt/workspaces/databases.d/adsbdb/backups"
making directory: "/opt/workspaces/logs.d/adsbdb"
env file /root/adsbdb.d/docker/env/.redis.env not found: stat /root/adsbdb.d/docker/env/.redis.env: no such file or directory
``

**Expected behavior**
Containers to be built and running as expected

**Desktop (please complete the following information):**
 - OS: Ubuntu 24.04, Docker version 27.3.1

**Additional context**

Cloned the repo into "/opt/adsb". Executing run.sh creates folders in my HOME folder (which should not be the case). I studied the bash script and if /workspaces exists, then it uses that folder. I created that, but the docker-compose file expects everything to be in $HOME which is not consistent with the run.sh script.

There should be a global folder for installation , editable by the user, or at least use the current folder, not $HOME from run.sh

Also, "env" folder doesn't exist, example ".env" files do not exist with some sample data hence rendering this app unusable for testing purposes
mrjackwills commented 1 month ago

The parse_env.rs file should go some way to explain which environmental variables are needed.

I can create a simple table for the readme which would list them, their expected type, and if they are required or not. However, without the underlying database data - which is something that so far isn't open source - the application is pretty much pointless.