mrjackyliang / homebridge-adt-pulse

Homebridge security system platform for ADT Pulse
MIT License
36 stars 7 forks source link

ADT Pulse Canada Support #37

Closed geoffreyspencer closed 4 years ago

geoffreyspencer commented 4 years ago

Describe the bug:

ADT Pulse not working in Canada

Steps to reproduce the bug:

  1. I cannot log-in because the plug-in is using the U.S. ADT Pulse site. I need to use the Canadian ADT Pulse site: https://portal-ca.adtpulse.com (note the -ca)

Expected behavior:

I would be able to log in to my ADT Pulse using the Canadian ADT Pulse service

The Apple device you are using:

Homebridge information:

Find these 4 lines in the beginning of the logs, then replace the text inside the grave accents:

[1/1/2020, 0:00:00 PM] [ADT Pulse] running on iMac (Intel - 64-bit)
[1/1/2020, 0:00:00 PM] [ADT Pulse] homebridge-adt-pulse v1.0.0
[1/1/2020, 0:00:00 PM] [ADT Pulse] node v12.13.0
[1/1/2020, 0:00:00 PM] [ADT Pulse] homebridge v0.4.50

I downloaded your code. I added another option to the configuration to select your country (U.S. or Canada). I updated the api.js to accept the country and updated the script to use either portal.adtpulse.com for U.S. or portal-ca.adtpulse.com for Canada. It needs to be tested. How do I get the code back to you for review, testing and publishing?

mrjackyliang commented 4 years ago

I maybe able to add support for ADT Pulse Canada. Although, I'm not sure if they are the exact same system, so I cannot guarantee compatibility.

Do you know what version the portal currently runs on?

geoffreyspencer commented 4 years ago

I wrote up something for you but I do not know where to send the three updated files? FYI, I am a software engineer but I have not use GitHub nor NPM yet.

Does this help?

Software provided by ICN Acquisition, LLC. Redwood City, CA USA www.icontrolone.com

Copyright © 2004-2020 ICN Acquisition, LLC. All Rights Reserved.

Icontrol One is a trademark of ICN Acquisition, LLC.

Web Portal version:   20.0.0-221
Gateway firmware version:   19.0.0-11
Gateway device version:   HW=2, BL=1.1.9, PL=9.4.0.32.5, SKU=PGZNG1-1ADNAS
geoffreyspencer commented 4 years ago

Sorry. I clicked the wrong button. Meant to click Comment but clicked "Close". Re-opened.

mrjackyliang commented 4 years ago

Can you edit the api.js file? You can change the URL from the US version to Canada version.

Just replace https://portal.adtpulse.com with https://portal-ca.adtpulse.com

Once you have successfully logged in, view the logs and don't close the tab. Then:

Please report back, once everything passes, I will add support for the Canada version officially. Thanks!

mrjackyliang commented 4 years ago

Just saw that you edited the comment.

If you have already tested it, you can fork the repository using GitHub, make the changes and then file a pull request in GitHub!

I then, will be able to see the changes.

geoffreyspencer commented 4 years ago

I found the local files. I changed portal.adtpulse.com to portal-ca.adtpulse.com and everything works. I am still testing. Once I satisfied things are working, I will send you my suggestions to have an option to select the country in the config settings and the code will choose either portal or portal-ca. More soon. Thanks for the guidance. Love the plugin!!! I will donate as soon as I am paid.

mrjackyliang commented 4 years ago

Thank you! Let me know if all the tests work and I'll implement the changes!

geoffreyspencer commented 4 years ago

Okay. Only one thing is not working and that is the motion sensor are being tripped but nothing is showing up in the Home app or in the Homebridge console log. I do see the trigger in the ADT portal. The doors' triggers are working. Not sure how to test the smoke detectors. The panel is working. I do not have a Home setting but Away, Stay and Off/Disarmed so I do not know what that state would do to the panel. Maybe nothing.

mrjackyliang commented 4 years ago

As far as I know, you're using the same version as the one used in the US.

When you do these tests, enable Test Mode in the ADT website. This prevents authorities from being called for the time being.

And Home is pretty much Arm Stay. That's how they say it in the Home app😁

mrjackyliang commented 4 years ago

Also, for the motion sensors, it is all of them that have this issue?

geoffreyspencer commented 4 years ago

Most of the sensors are working. It took a while but the sensors are reporting motion triggered now. Just not when they first appeared in the HomeBridge and the Home app. Weird. Is there a way to get specific type of arming when creating automation? I would like to get away triggered and night/stay triggered to behave differently. Away, turn off ALL the lights. Night, turn off the lights except for the bedrooms. I only see Armed trigger yet the Home app displays the type of arming that was selected.

mrjackyliang commented 4 years ago

Possibly the delay was caused by a HomeKit network issue. This frequently happens on mine after I started segregating the networks apart.

And yes. Advanced automations can be done through the use of Home+ app. I currently use it to build advanced automations!

geoffreyspencer commented 4 years ago

Fun while it lasted. The portal works but the devices are no longer responding in HomeBridge. Shame. I had a whole bunch of automated scripts set up in Home+.

mrjackyliang commented 4 years ago

Yeah, that sometimes can happen with HomeKit and Homebridge. Should be some local network issues.

mrjackyliang commented 4 years ago

ADT Pulse Canada is now supported with v1.9.0. Closing!

github-actions[bot] commented 8 months ago

This issue is now locked and considered resolved due to inactivity.