search

mrjoelkemp / html5-local-redis

Redis-like API for HTML5 Local Storage
http://mrjoelkemp.github.com/html5-local-redis/
MIT License
20 stars 0 forks source link

It can't be this easy, right!? #33

Closed eudisd closed 12 years ago

eudisd commented 12 years ago
Decr Commands - Round 1
Back after a long hiatus/injury.

The tests are pretty much the same as incr. At the moment, I'd like to keep them separate (ie not use a generic solution/test for both family of commands) just in case anything comes up.

eudisd commented 12 years ago

I fudged the commit message, I meant to rebase into 1 commit and clean it up. In any case, let me know if the documentation looks correct. Did not have enough time to learn it, so used the docs you already made for incr (copy/pasted/modified). My guess is that it's just Markdown at this point. I'll have to learn the sexy docs, hehe. Heading home from work now, should be there in an hour or so.

mrjoelkemp commented 12 years ago

Merging this. Take note of my comments and you can make those minor changes directly on master and push.

eudisd commented 12 years ago

Push directly into master!? Cowboy coding it is, haha. I'll make sure to be thorough before pushing to master. Thanks

mrjoelkemp commented 12 years ago

Well, it was only comment changes. If we were versioning the library, then pushing to master wouldn't fly. Cowboys indeed :)

On Tue, Oct 2, 2012 at 8:42 PM, Eudis Duran notifications@github.comwrote:

Push directly into master!? Cowboy coding it is, haha. I'll make sure to be thorough before pushing to master. Thanks

— Reply to this email directly or view it on GitHubhttps://github.com/mrjoelkemp/html5-local-redis/pull/33#issuecomment-9092328.

Ph.D. student in Computer Science, CUNY Graduate Center Adjunct Lecturer, NYU http://www.mrjoelkemp.com

eudisd commented 12 years ago

Alright, I made the changes on master. I'll go ahead and update trello. I think I'll work on some of the bugs/enhancements I have left.

mrjoelkemp commented 12 years ago

Btw, I didn't see a modification to local.redis.docs.html in your request. When you modify the local.redis.docs.js file, you need to run docco src/local.redis.docs.js in the terminal to update docs/local.redis.docs.html. You can then open that file in Chrome to see your changes to the documentation.

In terms of what to work on next, you can look at hashes. I'll finish up list commands. You should add another spec file and reference it in index.html (spec runner) to run your specs. Keep me posted on Trello about which commands you want to implement.

eudisd commented 12 years ago

Right, I figured I missed something with the docs. I'll run the script and check the file/push to master. I'll work on the hashing stuff, but first let me do some research. I'll post the commands I'll work on, on trello as you said.

eudisd commented 12 years ago

Alright, checked the modified docs before the push. Looks good. Thanks for the heads up.