search

mrjohannchang / zsh-interactive-cd

Fish like interactive tab completion for cd in zsh
Mozilla Public License 2.0
314 stars 37 forks source link

Case insensitive support #1

Closed mrjohannchang closed 3 years ago

hrai commented 4 years ago

Will there be any work on this feature?

Maneren commented 3 years ago

@changyuheng I have a PR for this, but while making it, I rewrote few chunks of the code in order to make it more readable (so I can understand it). Should I send it both as one PR or as two (cleanup and feature separately) PRs or send just the feature.

(I am quite new to collab programming, so I don't know whats the right way to do this)

mrjohannchang commented 3 years ago

Hi @Maneren, please do. I'll merge it as long as it's applicable.

Maneren commented 3 years ago

@changyuheng How's it looking?

mrjohannchang commented 3 years ago

@Maneren, thanks for the PR. Can you please split it into 2? It's perfect to just merge this: https://github.com/changyuheng/zsh-interactive-cd/pull/16/commits/d73de3fc77e40ee6f619b88ba27f83644a3d866d. For the cleanup, I think I'll do it by myself.

Maneren commented 3 years ago

Sure, no problem

Maneren commented 3 years ago

@changyuheng done