mrjones2014 / lighthaus.nvim

A Lua implementation of lighthaus-theme/vim-lighthaus
MIT License
64 stars 5 forks source link

`colorcolumn` on top of plain text #12

Closed marcelarie closed 2 years ago

marcelarie commented 2 years ago

I tried loading the settings before and after the plugin loads with not effect.

lightbug Here is the same line with visual lne to highlight the missing text: lightbug 2

My lighthaus.nvim setup:

require("lighthaus").setup({
    bg_dark = vim.env.SYS_THEME == "dark" and true or false,
    colors = {
        black = "#111111",
        fg_nc_statusline = "#888888",
    },
    lsp_underline_style = "undercurl",
})
-- maybe this command it's the cause ?
vim.cmd("highlight ColorColumn ctermbg=0 guibg=#111111")

On my config I have vim.wo.colorcolumn = "80" too.

version: NVIM v0.7.0-dev

mrjones2014 commented 2 years ago

Sorry, I’m not sure what the actual issue is, could you clarify?

marcelarie commented 2 years ago

No problem. The issue is that the colorcolumn goes on top of some text. For now I only detected it with plain text with not highlight.

recording: Peek 2022-03-01 12-20

comparison with gruvbox-flat: Peek 2022-03-01 12-25

mrjones2014 commented 2 years ago

Oh, I see. I’ll do some digging. I don’t use colorcolumn so I’m not sure off the top of my head how to fix it.

marcelarie commented 2 years ago

Thanks!!

mrjones2014 commented 2 years ago

I think it's because I was setting the fg color instead of bg color for ColorColumn by mistake. @marcelarie could you update and let me know if it's fixed?

mrjones2014 commented 2 years ago

you can also remove the vim.cmd line now, as it's redundant.

marcelarie commented 2 years ago

Yep now it's fixed!! Thanks!

mrjones2014 commented 2 years ago

No problem, glad I could help!