search

mrjones2014 / smart-splits.nvim

🧠 Smart, seamless, directional navigation and resizing of Neovim + terminal multiplexer splits. Supports tmux, Wezterm, and Kitty. Think about splits in terms of "up/down/left/right".
MIT License
906 stars 38 forks source link

ignored_filetypes and ignored_buftypes not working #14

Closed mehalter closed 2 years ago

mehalter commented 2 years ago

I can't seem to get the ignored_filetypes or ignored_buftypes options working No matter what I set it doesn't change the edge detection to ignore the set filetypes. This includes when I don't modify the setup and the default does nofile/quickfix/prompt. If I have the quickfix open and resize a window that isn't the quickfix it will resize it instead of keeping it as a constant size.

mrjones2014 commented 2 years ago

Whoops. I think I accidentally removed that behavior while debugging the other issue you had opened the other day. This should be fixed now by 96ae8e81654d4e92023e16b2b7b950fd15376fc4

mrjones2014 commented 2 years ago

Note that I also updated the config table and how you set it: https://github.com/mrjones2014/smart-splits.nvim#configuration

mehalter commented 2 years ago

Hm, maybe I'm doing something wrong or misinterpretting how it should work but I don't think that commit fixed it

mehalter commented 2 years ago

oh wait I see, I think that the buftypes is working but not the filetypes

mrjones2014 commented 2 years ago

Try again with 6dbd63baa7fddde6d83dc32851fa113749cf0af7

mehalter commented 2 years ago

One thing that I think is slightly unexpected is if there is only 2 windows say a quickfix list at the bottom and my normal file buffer. if I have quickfix as an ignored filetype and I try to resize my normal buffer up/down it resizes the quickfix where I would expect if I have it in the ignored_filetypes then I would need to go to the quickfix window to resize it.

mehalter commented 2 years ago

In this case would it make sense for no resizing to happen just as if I had only ones single window open

mrjones2014 commented 2 years ago

hmm... I'm not sure how it should behave in that case. If a buffer and quickfix are the only 2 windows, and you try to resize vertically, wouldn't you expect it to resize, despite ignore file/buf types?

Otherwise what would be the point of pressing the resize keymap to begin with?

mehalter commented 2 years ago

Yeah I can see that as a logical decision. I'm on board