search

mrjosh / helm-ls

⎈ Language server for Helm ⎈
MIT License
234 stars 15 forks source link

Let helm-ls show the values of templates #26

Open franroa opened 1 year ago

franroa commented 1 year ago

Hi there, this is a very nice plugin. I was wondering if you have in mind to replace the values in the templates where they are defined. That would be awesome feature. Thanks!

qvalentin commented 9 months ago

Can someone elaborate how this should be implemented? Hover is already working pretty well. Or do you mean inlay hints?

franroa commented 9 months ago

Inlay hints good also be a good option. I think not everyone is using that, though.

It would be really nice to show the values when the cursor is not in the line, and show the template when the cursor is in the line

qvalentin commented 2 months ago

https://github.com/user-attachments/assets/900c5083-d53c-45be-b6d5-0a56c8d04b97

I did some lua hacking in neovim and this is what i got by now.

It is using tree-sitter to get some nodes and then calls helm-ls with hover to get the text replacements.

Is there interest to turn this into a neovim plugin?

franroa commented 2 months ago

That looks pretty cool!

franroa commented 2 months ago

Can I post this on reddit? I think you could get more interested people there. In any case, I would like to have it

qvalentin commented 2 months ago

@franroa sure, go ahead.

qvalentin commented 2 months ago

I published the current wip version here: https://github.com/qvalentin/helm-ls.nvim

franroa commented 2 months ago

awesome! thanks!