search

mrjuda / space-travelerers

A hub for space missions updates, where users can join missions and book and dragons. Built with ReactJS/Redux, SASS, and API.
MIT License
0 stars 0 forks source link

Space Travelers Capstone Project #21

Open mrjuda opened 2 years ago

mrjuda commented 2 years ago

This is a 2-person Capstone group. Members: @mrjuda and @JoffreyNK Link to the project's Kanban Board: https://github.com/mrjuda/space-travelerers/projects/1

Omar-Muhamad commented 2 years ago

Changes Required ♻️

Hi @mrjuda and @JoffreyNK,

Nice job, you are almost there.

(Changes Required) Aspects to improve: ♻️

image

[Optional] suggestions:

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

mrjuda commented 2 years ago

Thank you @Omar-Muhamad We just fixed the issue.

youmari commented 2 years ago

Project Approved :trophy: :tada: 🟢

Hi @mrjuda , @JoffreyNK

Your project is complete! You have done it exceptionally well. it's time to merge it :100: Congratulations! 🎉

To Highlight :+1:

:heavy_check_mark: No linters error. :heavy_check_mark: Details PR title and description. :heavy_check_mark: Good commit messages.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification. You can also connect with me on slack

_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.