search

mrjvs / neatojs

Collection of neat JS tools
https://neatojs.com/
MIT License
27 stars 3 forks source link

[Guider] GitHub Pages workflow is invalid #29

Closed jonbarrow closed 6 months ago

jonbarrow commented 6 months ago

Describe the bug

The documentation on how to deploy to GitHub Pages (https://neatojs.com/docs/guider/guides/deploy/github-pages) uses an invalid workflow. The Upload step uses both working-directory and uses, which according to this comment on another issue is invalid. This causes the deployment to fail. Screenshot:

Screenshot from 2024-03-19 10-22-41

Which package/app is affected (leave empty if unsure)

Guider

Link to the code that reproduces this issue

No response

Steps to reproduce

Deploy using the current workflow

Expected Behavior

To not fail

Extra details

No response

mrjvs commented 6 months ago

I'll fix, in the meantime, you can remove the line that causing it to fail, with your configuration it shouldn't be needed. (the defaults will work)

mrjvs commented 6 months ago

Fixed in latest feature branch, will be published soon:tm: