search

mrkara / gtranslator

A fork of the original 2-91 branch of Gtranslator from http://projects.gnome.org/gtranslator
GNU General Public License v3.0
1 stars 0 forks source link

[bgo#771765] Problem with 80 character lines and header comments #17

Open mrkara opened 7 years ago

mrkara commented 7 years ago

When parser adds the current year to header comments, sometimes it generates a new line, starting with ",", and this breaks PO file structure.

This behaviour seems to be due to an 80 characters per line limitation. I've searched in the source code, but didn't find where this limit is set...

The file whre this comment is added to PO file is gtr-header.c, lines 682-690, but I think the problem is not there, but might help to investigate.

Could somebody please help with this issue? Please note that severity of this bug is high, because if PO file has a wrong structure, module's build might fail.

Thanks in advance

Originally reported by Daniel Mustieles at https://bugzilla.gnome.org/show_bug.cgi?id=771765

mrkara commented 7 years ago

Investigating, the 80 characters limitation is done by gettext...

Maybe a good idea would be to reduce the line's lenght, instead of adding the full list of years, just left a 'first_year - last_year' field would be enough to avoid the problem.

This should be relatively easy to do... would you consider it as a valid fix for this issue?

Originally posted by Daniel Mustieles