mrkara / gtranslator

A fork of the original 2-91 branch of Gtranslator from http://projects.gnome.org/gtranslator
GNU General Public License v3.0
1 stars 0 forks source link

[bgo#552720] Gtranslator should allow going back to previous translation #35

Open mrkara opened 7 years ago

mrkara commented 7 years ago

Currently gtranslator does not allow going back to previous "touched" message. It is useful to be able to go back and forward between touched messages.

While you're only translating fuzzy or untranslated messages you end up passing a message while you know you need to turn back and fix/change something. However currently you can't do that, only neighbour messages can be iterated.

Originally reported by Baris Cicek at https://bugzilla.gnome.org/show_bug.cgi?id=552720

mrkara commented 7 years ago

A list of visited messages can be kept in GtranslatorTab in a separate SList. And Next/Previous menu items can alter that list. Another int can store index on SList while -1 states the last item. Every visit on message would add one more item to SList.

If proposed method ok, then I can send patch for it.

Originally posted by Baris Cicek

mrkara commented 7 years ago

Created attachment 118988 Proposed patch

Adds ability to go back between translated messages. Every changed message gets in message history. Left/Right goes between translated messages.

If you go back and translated another message then since order is changed Forward movements get dissapear.

This is controversial. Would it be better to insert inside queue instead of losing forward queue?

Originally posted by Baris Cicek

Attachment: https://bugzilla.gnome.org/attachment.cgi?id=118988

mrkara commented 7 years ago

This is very useful. The patch seems to be ok but I think "modified" would be a better word instead of "touched". If you agree with this minor change I will upload the patch.

Thanks!

Originally posted by Pablo Sanxiao

mrkara commented 7 years ago

Sure.

Originally posted by Baris Cicek

mrkara commented 7 years ago

What happened with this new feature? I also think It's very useful, and It would be great if it's finally committed

Originally posted by Daniel Mustieles

mrkara commented 7 years ago

Ping?

Originally posted by Daniel Mustieles