Open mrkara opened 7 years ago
Review of attachment 212535:
functions should be aligned more to the center. i.e see gtr-msg.h
Originally posted by Ignacio Casal Quinteiro (nacho)
Created attachment 212544 gtr-actions.h fixed
Originally posted by Daniel Mustieles
Attachment: https://bugzilla.gnome.org/attachment.cgi?id=212544
Review of attachment 212544:
Looks good. Although I'd rather just one patch for the core and another for the plugins.
Originally posted by Ignacio Casal Quinteiro (nacho)
Ok, don't worry. I just wanted to ensure if the format was correct.
I'm preparing a patch for the core and another patch for the plugins
Originally posted by Daniel Mustieles
Created attachment 212562 Core headers fixed
Originally posted by Daniel Mustieles
Attachment: https://bugzilla.gnome.org/attachment.cgi?id=212562
Created attachment 212563 Patch merged with git changes
Please review this patch, since it has been merged with git changes, but it doesn't work properly
Originally posted by Daniel Mustieles
Attachment: https://bugzilla.gnome.org/attachment.cgi?id=212563
Created attachment 212590 PAtch working
Originally posted by Daniel Mustieles
Attachment: https://bugzilla.gnome.org/attachment.cgi?id=212590
Created attachment 212607 Path to fix plugins headers
Originally posted by Daniel Mustieles
Attachment: https://bugzilla.gnome.org/attachment.cgi?id=212607
Comment on attachment 212607 Path to fix plugins headers
Pushed a modified version using spaces and other cleanups.
Originally posted by Ignacio Casal Quinteiro (nacho)
Attachment: https://bugzilla.gnome.org/attachment.cgi?id=212607
Created attachment 212535 Partial patch. Just tell me if this is the correct format. If it is, I'll modify .h files according to it
We should unify indentation in .h files.
Originally reported by Daniel Mustieles at https://bugzilla.gnome.org/show_bug.cgi?id=674560