mrkara / gtranslator

A fork of the original 2-91 branch of Gtranslator from http://projects.gnome.org/gtranslator
GNU General Public License v3.0
1 stars 0 forks source link

[bgo#674560] Fixed indentation in header files #49

Open mrkara opened 7 years ago

mrkara commented 7 years ago

Created attachment 212535 Partial patch. Just tell me if this is the correct format. If it is, I'll modify .h files according to it

We should unify indentation in .h files.

Originally reported by Daniel Mustieles at https://bugzilla.gnome.org/show_bug.cgi?id=674560

mrkara commented 7 years ago

Review of attachment 212535:

functions should be aligned more to the center. i.e see gtr-msg.h

Originally posted by Ignacio Casal Quinteiro (nacho)

mrkara commented 7 years ago

Created attachment 212544 gtr-actions.h fixed

Originally posted by Daniel Mustieles

Attachment: https://bugzilla.gnome.org/attachment.cgi?id=212544

mrkara commented 7 years ago

Review of attachment 212544:

Looks good. Although I'd rather just one patch for the core and another for the plugins.

Originally posted by Ignacio Casal Quinteiro (nacho)

mrkara commented 7 years ago

Ok, don't worry. I just wanted to ensure if the format was correct.

I'm preparing a patch for the core and another patch for the plugins

Originally posted by Daniel Mustieles

mrkara commented 7 years ago

Created attachment 212562 Core headers fixed

Originally posted by Daniel Mustieles

Attachment: https://bugzilla.gnome.org/attachment.cgi?id=212562

mrkara commented 7 years ago

Created attachment 212563 Patch merged with git changes

Please review this patch, since it has been merged with git changes, but it doesn't work properly

Originally posted by Daniel Mustieles

Attachment: https://bugzilla.gnome.org/attachment.cgi?id=212563

mrkara commented 7 years ago

Created attachment 212590 PAtch working

Originally posted by Daniel Mustieles

Attachment: https://bugzilla.gnome.org/attachment.cgi?id=212590

mrkara commented 7 years ago

Created attachment 212607 Path to fix plugins headers

Originally posted by Daniel Mustieles

Attachment: https://bugzilla.gnome.org/attachment.cgi?id=212607

mrkara commented 7 years ago

Comment on attachment 212607 Path to fix plugins headers

Pushed a modified version using spaces and other cleanups.

Originally posted by Ignacio Casal Quinteiro (nacho)

Attachment: https://bugzilla.gnome.org/attachment.cgi?id=212607