search

mrkaye97 / slackr

An R package for sending messages from R to Slack
https://matthewrkaye.com/slackr/
Other
307 stars 84 forks source link

Support R version #123

Closed woowahan-jaehoon closed 3 years ago

woowahan-jaehoon commented 3 years ago

Hi.

I checked that slackr 2.0.1 support only over R 4.0.0 but I think that many users are using under R 4.0.0 and I do.

Could you change to back R depends version? (https://github.com/hrbrmstr/slackr/blob/master/DESCRIPTION)

I checked that it works when I changed R depends version to over 3.0.0 and I used R 3.6.3.

woowahan-jaehoon commented 3 years ago

I checked commit about R depends version was changed, but I think that it have no something change about syntax, etc. https://github.com/woowahan-jaehoon/slackr/commit/3e76aa09f4537160557bd9be49a686491bf0f7c7

mrkaye97 commented 3 years ago

Yes, if it works on 3.6.3, that's fine. I will test first.

@hrbrmstr any objection to me setting up Github Actions to run devtools::check() on pushes? That'd make things like testing multiple OS / R versions pre-merge easier.

mrkaye97 commented 3 years ago

This is done as of slackr 2.0.2. Thanks for putting in the request!