search

mrkaye97 / slackr

An R package for sending messages from R to Slack
https://matthewrkaye.com/slackr/
Other
307 stars 85 forks source link

Use numeric values for timestamps #186

Closed mrkaye97 closed 1 year ago

mrkaye97 commented 1 year ago

Is your feature request related to a problem? Please describe. Right now, slackr expects (implicitly) and returns strings as timestamps. That's silly -- we should use floats to represent timestamps instead. That would make (e.g.) comparisons of timestamps dramatically more intuitive.

Describe the solution you'd like All functions should accept numeric timestamps for (e.g.) thread_ts (or try to coerce chars to numeric and fail if not possible) and should return numeric timestamps for (e.g.) ts

mrkaye97 commented 1 year ago

Turns out this was a bad idea -- the API doesn't like numeric timestamps much