search

mrkaye97 / slackr

An R package for sending messages from R to Slack
https://matthewrkaye.com/slackr/
Other
307 stars 83 forks source link

files.upload method is deprecated. Upcoming breakage of `slackr::file_upload()` #200

Open davidski opened 4 months ago

davidski commented 4 months ago

The Slack files.upload method is being deprecated. New applications created after May 8th will not be able to use it and pre-existing apps will loose access in March of 2025. There are new methods to replace it files.getUploadURLExternal and files.completeUploadExternal.

We'll need to retool to continue to have file attachment functionality. Opening a tracking issue here for anyone (myself included) that may have time to work up a PR.

mrkaye97 commented 4 months ago

Thanks for putting this in! I'll look into it in the next couple weeks. I suspect it'll be a pretty straightforward change, but I also haven't touched the tests or anything in a year or two (and my engineering skills are better now than they were then :P), so there are probably other flaky breakages.

Feel free to put in a PR for this if you want. I'd like to bundle in a test change that adds mocks to all the API calls instead of calling the real APIs from CI as well.

stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.