search

mrkite / TerraFirma

Mapping for Terraria
http://seancode.com/terrafirma
BSD 2-Clause "Simplified" License
278 stars 61 forks source link

Show more information (e.g. icons) next to "Find item" dialog entries, and make jump immediate #5

Closed flying-sheep closed 9 years ago

flying-sheep commented 11 years ago

Hi! it's so awesome how you adapted my amateurish code. that's how i would have written it if i knew anything about WPF/C# :)

I have two minor suggestions, though:

  1. The listed items should have their icons next to them, and the associated chests theirs, as well as maybe the coordinates (you save the chest number in the ChestLeaf, so you could add a chestType field to the chest struct, and make the TreeView template/renderer retrieve the chest icon from that)
  2. It would be nice to make the dialog nonmodal, and the jump to the selected chest immediate without clicking "Find". that way, users can try more than one chest. (Show() instead of ShowDialog(), and jumping as event handler instead of after-dialog code)