Open Delvin4519 opened 1 year ago
What is "wrong" with these colors?
stony peaks is using the mushroom island color. meadows are using the desert color. snowy peaks are using the swamp color. snowy slopes are using the desert hills color. this makes it really confusing and causes confusion between actual swamps and deserts versus mountain biomes since they use the same color (mountains are wrong color).
RGB Values that are used:
Stony Peaks BF 00 FF
Mushroom Fields FF 00 FF
Meadow FF 95 00
Desert FA 94 18
Snowy Slopes 00 FF D5
Swamp 07 F9 B2
So no, they do not use "the same" color. But yes, the color is maybe not chosen well.
It is on my list to rework Biome colors anyway (mostly 1.18). I'm not sure if I will do that this summer. But if you like, you can suggest "better" colors. At the moment good colors are missing definitely for: "minecraft:meadow", "minecraft:mountain_meadow" "minecraft:grove", "minecraft:mountain_grove" "minecraft:snowy_slopes", "minecraft:frozen_peaks", "minecraft:lofty_peaks" "minecraft:snow_capped_peaks" "minecraft:stony_peaks", "minecraft:jagged_peaks", "minecraft:lush_caves",
These are the biome colors for 1.18+ biomes that better correlate with the mountain biomes (AMIDST has all colors 1.17 and below). Chunkbase and cubiomes use similar colors for 1.18+ biomes. Since 1.20 cherry grove will be added, it will be shown here:
minecraft:meadow = #60A445
minecraft:stony_peaks = #7B8F74
minecraft:grove= #47726C
minecraft:jagged_peaks = #DCDCC8
minecraft:snowy_slopes = #C4C4C4
minecraft:frozen_peaks = #B0B3CE
minecraft:lush_caves = #283C00
minecraft:dripstone_caves = #4E3012
minecraft:deep_dark = #031F29
minecraft:mangrove_swamp = #24C48E
minecraft:cherry_grove = #FF91C8
Cherry Grove was already added with same color than Chunkbase: #F7B9DC
I'm in contact with Cunkbase to align colors in the future. That is the job for this summer.
We used all AMIDST colors as long as this project was alive (up to 1.17). 1.18 and 1.19 was just random colors and with 1.20 I started to align with Chunkbase.
Could you please describe in more detail how you get to your colors? A description of a method, algorithm or other way to explain why the color is exactly like it is.
Here are some examples from my color choice:
#bc8f8f
is located underground with large caves, so it should have some visible contrast on deeper Y levels. A very distinctive Block in these Biome is the Dripstone. Therefore I selected a color similar to it.#F7B9DC
by chance I had Chunkbase open in that moment and I liked the color used there and just took it.Chunkbase has the colors for 1.18/1.19 biomes, they should be similar to the colors above. The colors listed are from cubiomes.
I supposed the chunkbase colors could be used instead.
Link to color definition in cubiomes repository: https://github.com/Cubitect/cubiomes/blob/960d5d64b61125eb09e72bfec70a0ffe439d01b0/util.c#L263
Alright, the new colors seem to be an improvement. One suggestion, change "Unknown Biome", to render as #000000
color, since it seems to be falling back to plains biome color, which causes confusion with unloaded chunks in the biome map view.
Yes, color alignment is in progress...
A very dark color might be mixed up with minecraft:deep_dark
.
But at the moment it seems to be a random color for Unknown Biome, which is also not ideal.
Snowy peaks, etc, all have the wrong biome color