mrkite
commented
1 year ago Ignoring zero-sized bounding boxes would be better than to single out a specific mod.
On Fri, Jun 9, 2023 at 11:29 AM rjp @.***> wrote:
[image: Screenshot 2023-06-09 at 11 45 40] https://user-images.githubusercontent.com/10793/244762310-6f4f34e2-e6a0-42ee-b51f-d4f4bd0a3034.png
They are weird structures since they have a zero-sized bounding box. e.g. terralith:zpointer/minecraft_lush_caves -> [2256, 32, 2688, 2256, 32, 2688]
Had a go at fixing this in two ways - first was adding a JSON file containing structure prefixes to ignore (Structure.terralith:zpointer). Second was ignoring structures with a zero-sized bounding box.
Don't know whether one or the other covers more mods or whether both are needed. Happy to create a PR with either / both.
— Reply to this email directly, view it on GitHub https://github.com/mrkite/minutor/issues/359, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGASZ7JC4MMZHANKLCFQVTXKNTR5ANCNFSM6AAAAAAZA7JZ5U . You are receiving this because you are subscribed to this thread.Message ID: @.***>
EtlamGit
rjp
They are weird structures since they have a zero-sized bounding box. e.g.
terralith:zpointer/minecraft_lush_caves -> [2256, 32, 2688, 2256, 32, 2688]Had a go at fixing this in two ways - first was adding a JSON file containing structure prefixes to ignore (
Structure.terralith:zpointer). Second was ignoring structures with a zero-sized bounding box.Don't know whether one or the other covers more mods or whether both are needed. Happy to create a PR with either / both.