mrkite / minutor

Mapping for Minecraft
http://seancode.com/minutor
BSD 2-Clause "Simplified" License
278 stars 52 forks source link

Fix playname query #373

Closed EtlamGit closed 9 months ago

EtlamGit commented 9 months ago

Mojang has changed their API (deprecating the part we used in the past)

This PullRequest 1) changes the API entry point to get the player name to a variant that still works. 2) downloads the player skin texture and uses the face as icon in the jump to player menu

All player data is cached and only queried once.

EtlamGit commented 9 months ago

grafik

mrkite commented 9 months ago

Beautiful.

EtlamGit commented 9 months ago

You are very fast with merging today . . . There is a compile issue with Qt 5.9. I will add a PullRequest for that!

mrkite commented 9 months ago

Yeah I saw that. If it's easy to fix, by all means.

EtlamGit commented 9 months ago

Yes, the fix was ready at the moment I realized that you merged already ;-)