search

mrkjffrsn / RokuFramework

An opensource Roku framework
Apache License 2.0
47 stars 10 forks source link

Use of eval() in UnitTestFramework.brs breaks with OS 9.3 #22

Open bbonet-entercom opened 4 years ago

bbonet-entercom commented 4 years ago

OS 9.3 Any apps using this framework will not load. Your app will be broken. As this framework was used on our current roku app, our quick solution was to just comment the two eval() lines out. Obviously this is not good for unit testing, but it's a quick way to re-submit your app and getting it running again in the short term.

mrkjffrsn commented 4 years ago

Thank you for noting this. The eval expression is used within the Roku unit test framework. Roku has released a new version of their unit testframework that does not use eval. Updating the unit test framework to the latest one should fix this.

I'll have a patch fix for it soon.

bbonet-entercom commented 4 years ago

Thanks. I didn't realize it was the official testing framework (I'm a newb). I replaced it with the latest and problem solved. Thanks! Looking forward to that update still!

mrkjffrsn commented 4 years ago

@bbonet-entercom @jfrux as updated the unit test framework. I've left some comments on where you can find on porting all the test cases to work with the new framework. I'll push another update porting the existing test cases on the framework here soon.