Closed msakai closed 1 year ago
Hey, I think it is a good idea. Maybe we should be more brave about it though: provide no pattern synonyms for compatibility, but instead bump to version 2.0.0?
Can you please
Sure!
I fixed the code to satisfy Ormolu, removed pattern synonyms, bumped the version to 2.0, and updated CHANGELOG.md
.
Thanks!
This PR contains two changes:
Currently,
BZip2Unsupported
andZstdUnsupported
are defined only when the library is built without support for respective compression methods. But this means it is necessary to know under which configuration thezip
library is built to handle those exceptions. Using conditional compilation based on the information is a burden for application development. So I propose to define those data constructors unconditionally.Since the only difference between
BZip2Unsupported
andZstdUnsupported
are compression method, I propose to unify them as a single data constructorUnsupportedCompressionMethod
. This makes it easier to add other compression methods in the future. Compatibility is maintained using pattern synonyms.