search

mrkkrp / zip

Efficient library for manipulating zip archives
Other
81 stars 27 forks source link

Fix setting archive version #63

Closed qnikst closed 4 years ago

qnikst commented 4 years ago

This PR fixes setting archive version so unzip tool handles, permissions set by the library well. In addition in introduces the helpers for converting unix permissions into the external file attributes value.

Fixes #62.

qnikst commented 4 years ago

To be honest, having those docs in the package would have saved at least 2 hours of my life. It was not that easy to find relevant documentation that is complete enough. Though I get why you don't want to keep that in package docs.

Wrt System.POSIX.Types, thanks I've missed that they are in base as well.

mrkkrp commented 4 years ago

To be honest, having those docs in the package would have saved at least 2 hours of my life.

This is understandable, but now we have functions that work as a complete solution to this problem, so explaining the algorithm itself is not necessary.

mrkkrp commented 4 years ago

Released 1.4.0 with the changes.