search

mrklein / openfoam-os-x

Patches for OpenFOAM(R) to build it on OS X
92 stars 33 forks source link

tap mrklein/foam #69

Open AleksZhuravlyov opened 2 years ago

AleksZhuravlyov commented 2 years ago

Looks like lines below from wiki:

$ brew install scotch $ brew install parmgridgen

should be changed as follows:

$ brew install mrklein/foam/scotch $ brew install mrklein/foam/parmgridgen

Otherwise brew reinstalls scotch from homebrew/core if brew upgrade is run.

mrklein commented 2 years ago

Thank you for the report. In fact, maybe I should remove tap mrklein/foam, since this tap originated as a temporary solution, when scotch was removed from core (or rather was not migrated there). core has newer version and community maintained, while version in my tap is rather old.

I will test build with core's version and update wiki accordingly.

AleksZhuravlyov commented 2 years ago

This newer version of scotch does not include ptscotch.h which is required for OpenFoam, while version from your tap mrklein/foam works pretty good.

mrklein commented 2 years ago

It does. Formula in homebrew/core builds library incorrectly. Theoretically this should be reported to Homebrew, yet, practically it is simpler to fix this issue in custom tap. So, you are right, wiki should be corrected.

BrushXue commented 2 years ago

Now pt-scotch is finally added to homebrew/core. However, they don't allow me to drop -DSCOTCH_PTHREAD option, saying it is outdated and shouldn't cause any MPI problem in 2021 (which is not true for OpenFOAM). Please file complaints to make them aware of this issue. The simple fix is to add (I tested)

        s.gsub! "-DSCOTCH_PTHREAD", ""