search

mrklein / openfoam-os-x

Patches for OpenFOAM(R) to build it on OS X
93 stars 33 forks source link

Can you add the patch for OpenFOAM-v1812? #73

Closed friedenhe closed 2 years ago

friedenhe commented 2 years ago

We wonder if you can make a patch for OpenFOAM-v1812. Thanks!

mrklein commented 2 years ago

Yes, I can. But I do not see a reason why.

friedenhe commented 2 years ago

Great! We developed a discrete adjoint capability for design optimization with OpenFOAM (check here). Our code is based on OpenFOAM-v1812 and it is hard for us to upgrade to a newer OF version. We tried to follow the wiki and managed to compile OF on MacOS. However, it seems that the oldest supported version is v1912, so we wonder if you can add the v1812 patch. Thanks again!

mrklein commented 2 years ago

Well, I see the reason why you need it, I still do not see the reason why should I create it.

olesenm commented 2 years ago

Great! We developed a discrete adjoint capability for design optimization with OpenFOAM (check here). Our code is based on OpenFOAM-v1812 and it is hard for us to upgrade to a newer OF version. We tried to follow the wiki and managed to compile OF on MacOS. However, it seems that the oldest supported version is v1912, so we wonder if you can add the v1812 patch. Thanks again!

@friedenhe - instead of requesting patches for older versions of OpenFOAM, you would do better to see what is actually needed to update your code to a newer version of OpenFOAM. In addition to the upgrade guides, you can probably also refer to corresponding parts of the OpenFOAM source code to see which changes are needed.

If we compare the upstream checkTools.C and your checkTools.C, there is an obvious amount of overlap. You should easily be able to apply an update there, but preferably not remove the copyright and license information this time!!

friedenhe commented 2 years ago

@olesenm, thanks very much for the suggestions! We will add the copyright and license info back. Yes, we are trying to upgrade our code with higher versions of OpenFOAM. The main DAFoam code should be straightforward to upgrade, the tricky part is that we used an automatic differentiation tool to overload all data types in OpenFOAM and differentiate its source code on this OpenFOAM-v1812-AD repo. Upgrading that repo for a higher version of OpenFOAM may need some work. You left a message for us and suggest we rebase our code to upstream. We've just started doing that and may need your help. I left a message for you there. Thanks!

mrklein commented 2 years ago

Guess, v1812 is not relevant any more?