search

mrkn / mxnet.rb

MXNet binding for Ruby
MIT License
48 stars 10 forks source link

Merging #33 #36

Closed mrkn closed 5 years ago

mrkn commented 6 years ago

In this pull-request, I want to merge @toddsundsted's works for implementation of Gluon based on my work-in-progress code base.

toddsundsted commented 6 years ago

@mrkn if i can make any changes to my code to make the merge easier, just let me know!

mrkn commented 6 years ago

@toddsundsted Thank you for your kindness. I'll ask you to change something if I need.

mrkn commented 5 years ago

@toddsundsted I didn't import adf9d7c because this refactoring changes the superclass of SymbolBlock class. I want to make the class hierarchy same as Python's.

mrkn commented 5 years ago

@toddsundsted I marked the examples I cannot fix in this PR as pending.

The remaining work is fixing for passing CI only. I'll merge this PR after that.

toddsundsted commented 5 years ago

@mrkn I'm fine with leaving adf9d7c out. generally I prefer consistency with Python, as well -- I just couldn't resist trying to fix the bad design here...

toddsundsted commented 5 years ago

woohoo!