Use MXSymbolSetAttrs instead of MXSymbolSetAttr in MXNet::Symbol#set_attributes

mrkn / mxnet.rb

MXNet binding for Ruby

MIT License

48 stars 10 forks source link

Use MXSymbolSetAttrs instead of MXSymbolSetAttr in MXNet::Symbol#set_attributes #40

Closed mrkn closed 5 years ago

mrkn commented 5 years ago

The current implementation of MXNet:Symbol#set_attributes uses MXSymbolSetAttr for each key-value pair of specified attributes. It can be rewritten to call MXSymbolSetAttrs.

toddsundsted commented 5 years ago

Opened https://github.com/mrkn/mxnet.rb/pull/41.

It turns out MXSymbolSetAttrs does not exist. The Python code was (I believe, incorrectly) modified, however the modified method is redefined in all existing base classes, so the error wasn't noticed. In any case, this PR achieves our objectives.

mrkn commented 5 years ago

Resolved by #41