search

mrkn / pycall.rb

Calling Python functions from the Ruby language
MIT License
1.05k stars 72 forks source link

#121 - Revert "Remove conda checking" #135

Closed jmarrec closed 3 years ago

jmarrec commented 3 years ago

This reverts commit 2752e2e85a328bdbf251e859b902deaac4b2c182 and will, once again, not try to set the PYTHONHOME on my system.

Setting the PYTHONHOME is usually not a good idea, there are very very few cases where it makes sense. And it seems that in this specific case, trying to do it (PYTHONHOME is not defined in my environment) was breaking the work of python's Lib/site.py, which does that in a much saner way to begin with

With it, I no longer get problems as described in issue #121

mrkn commented 3 years ago

I'm checking the effect of this change in #139.

mrkn commented 3 years ago

I confirmed this fixes the issue on CI in #139. Thank you very much!

jmarrec commented 3 years ago

@mrkn thank you the review and merge!