mrkrd / cochlea

Inner ear models for Python
GNU General Public License v3.0
108 stars 42 forks source link

human group delay #8

Closed jundurraga closed 6 years ago

jundurraga commented 6 years ago

Dear all, First, thanks for sharing your code. I'm using it and it is really neat! I have been using the model available via pip but I have also been looking at your code here. What is not clear to me is why for the human_group_delay the beta value from Harte et al. 2009 is being divided by 2. I can see in the code that the human_group delay is not being used (cat instead) but if this happens, then the beta value needs to be corrected. Could I kindly ask you what group_delay is implemented in the available code in pip repository? Kind regards, Jaime

mrkrd commented 6 years ago

I have been using the model available via pip but I have also been looking at your code here. What is not clear to me is why for the human_group_delay the beta value from Harte et al. 2009 is being divided by 2. I can see in the code that the human_group delay is not being used (cat instead) but if this happens, then the beta value needs to be corrected.

I guess that you are talking about the model from Zilany et al. This Python package is just a repository of auditory models by other authors. I try to make it as close to the original as possible. The best if you could contact the original authors of the model with your questions.

Please let me know later, what was their response. Thanks!

Could I kindly ask you what group_delay is implemented in the available code in pip repository?

Pip code mirrors the github repo (all versions are tagged).

Marek