Python 3 compatibility - Githubissues

dajuro commented 9 years ago

Using six and UTF-8 as default encodign for strings, I got python 3 support running without loosing support for python 2.

Tested using the test_matlab.py: 4 tests fail using python 2.7, linux:

test_put_get_series, test_put_get_dataframe, test_get_uninitialized_struct, test_get_struct: "TypeError: data type not understood" when trying to create expected(!) array. Maybe somethings wrong with my python 2, I have no clue whats going on there.

2 tests fail using python 3.4, linux:

test_put_get_dataframe: expected array is wrong, semantically ok
test_get_struct: expected array is wrong, semantically ok

mrkrd commented 9 years ago

That's great! I'll check this PR in a few days. Thanks!

mrkrd commented 9 years ago

I have just merged your changes into python3 branch. Thanks to you python3 branch is moving forward.

python3 branch still needs some work before it can be merged onto master. It should pass all tests and it throws many exceptions on Windows. I would also like to fix the char array issue (char_array branch) too.

I have added your name to the contributors in AUTHORS.rst.

dajuro commented 9 years ago

Thanks for adding me as a contributor. Btw: this project is really helping me, so thank you for the great work!

mrkrd / matlab_wrapper

Python 3 compatibility #7