Add unit test for createChecklist() - Githubissues

mrkschan / codereviewmd

:page_with_curl: - Create code review checklist automatically on Github Pull Request [Discountined]

MIT License

7 stars 1 forks source link

Add unit test for createChecklist() #15

Closed mrkschan closed 8 years ago

mrkschan commented 8 years ago

Hey reviewers, please check the followings if appropriate.

[ ] Feature should be Heroku friendly.
[ ] Prevent oneliner if-statement.
[ ] Use early return for negative case as much as possible.
[ ] Validate all external inputs (including data from partner API).
[ ] Error or failure cases are handled.
[ ] Provide actionable error message as much as possible.
[ ] Unit test friendly interface and unit test included.

p.s. You may find the reason behind each check at https://github.com/mrkschan/codereviewmd/wiki/Pull-Request-Checklist.