search

mrkschan / nginxbeat

Superseded by https://github.com/elastic/beats/tree/master/metricbeat
Apache License 2.0
58 stars 7 forks source link

Nginx plus integration test #41

Closed mrkschan closed 8 years ago

ruflin commented 8 years ago

@mrkschan Wasn't aware that cover is part of the standard repo. Good to know, means we can also remove it on our side.

mrkschan commented 8 years ago

close #35

mrkschan commented 8 years ago

@ruflin Actually, I find that the docker container cannot go get it and then took a look at the docs of cover, where I find it's no longer maintained according to the docs.

FYI, find below the error message from the docker container.

mkdir -p build/coverage
# coverage tools
go get golang.org/x/tools/cmd/cover
package golang.org/x/tools/cmd/cover: unrecognized import path "golang.org/x/tools/cmd/cover"
scripts/Makefile:70: recipe for target 'prepare-tests' failed
make: *** [prepare-tests] Error 1
ruflin commented 8 years ago

Removing it in all our beats: https://github.com/elastic/beats/pull/1072