gotestcover is deprecated

[pierrre]

Please read https://github.com/pierrre/gotestcover#deprecated

[ruflin]

@pierrre Thanks for the heads up. I have to apply this to https://github.com/elastic/beats

[pierrre]

@ruflin Are you OK with my new script? It does exactly the same thing.

[ruflin]

@pierrre Will test it in the next hours / days as soon as I get the time for it.

[ruflin]

@pierrre Only did a very brief test and got the error: `cannot use test profile flag with multiple packages``

Our code looks as following:

$(GOPATH)/bin/gotestcover $(RACE) -coverprofile=${COVERAGE_DIR}/unit.cov  ${GOPACKAGES}

I assume the package list is the problem. No sure if I should put this in case of go list?

[pierrre]

@ruflin have you read the new script that replaces gotestcover? https://github.com/pierrre/gotestcover#deprecated

echo 'mode: atomic' > coverage.txt && go list ./... | xargs -n1 -I{} sh -c 'go test -covermode=atomic -coverprofile=coverage.tmp {} && tail -n +2 coverage.tmp >> coverage.txt' && rm coverage.tmp

[ruflin]

I wanted to paste the modified line of course that I tried out...

echo 'mode: atomic' > coverage.txt && go list ./... | xargs -n1 -I{} sh -c 'go test $(RACE) -coverprofile=${COVERAGE_DIR}/unit.cov  ${GOPACKAGES} && tail -n +2 coverage.tmp >> coverage.txt' && rm coverage.tmp

[pierrre]

I use it in my project: https://github.com/pierrre/imageserver/blob/master/.travis.yml#L24 It works: https://travis-ci.org/pierrre/imageserver/jobs/130788141#L223

[pierrre]

OK I understand. What is ${GOPACKAGES} in your script?

No sure if I should put this in case of go list?

Yes, try that

[pierrre]

Please try

echo 'mode: atomic' > ${COVERAGE_DIR}/unit.cov && go list ${GOPACKAGES} | xargs -n1 -I{} sh -c 'go test $(RACE) -covermode=atomic -coverprofile=coverage.tmp {} && tail -n +2 coverage.tmp >> ${COVERAGE_DIR}/unit.cov' && rm coverage.tmp

[ruflin]

Looks like this gets the job done. Thanks.

Now I need to find a way how to make this line shorter / less complex again as we have it multiple times: https://github.com/elastic/beats/blob/master/libbeat/scripts/Makefile#L124

[pierrre]

You could paste this script in a bash file and run it each time you need it. But it does not allow you to customize arguments for each call.

In my projects, I've copied/pasted this small script :)

[pierrre]

I'm sorry if this deprecation notice is too abrupt for you. But I find this new solution easier to maintain and more customizable.

(FYI I love Go and I hate bash scripts)

[ruflin]

@pierrre No worries, I really appreciate that you actively inform that the project will not be maintained anymore in the future and even provide a replacement script. The script will work quite well in our Makefiles, no worries.

I don't have it on top of my priority list as gotestcover works and I assume the repo will stay around a little bit.

[pierrre]

Don't be afraid, I will not remove the repository :)