search

mrkschan / nginxbeat

Superseded by https://github.com/elastic/beats/tree/master/metricbeat
Apache License 2.0
58 stars 7 forks source link

Add support for watching multiple Nginx instances #9

Closed mrkschan closed 8 years ago

mrkschan commented 8 years ago

Resolve #1.

mrkschan commented 8 years ago

Hey @ruflin, would you mind to take a look at https://github.com/mrkschan/nginxbeat/pull/9/files#diff-edf2363e464e98a98f11ccb6671e1d6dR98? Am I going to the right direction on watching multiple Nginx instances?

ruflin commented 8 years ago

@mrkschan Just had a quick look but I think it goes in the right direction. Does it work as expected or do you have any issues?

mrkschan commented 8 years ago

It's working though i just wanna check if using goroutine like that is a good practice. thx for taking a look, @ruflin :)