mrkwnzl / cyphersystem-foundryvtt

The Cypher System for Foundry VTT
Other
21 stars 14 forks source link

Activeeffects #308

Closed farling42 closed 1 year ago

farling42 commented 1 year ago

Before creating a PR, please make sure you have read the Contribution Guidelines

Please target the develop branch with all PRs! Thank you!

Proposed changes Here is some non-conflicting code which adds an FX tab to PC Actor sheets as well as various types of Item sheets which allow the creation of ActiveEffects. Core foundry supports the actor inheriting FX from Items, and the Active Token Effects module allows effects on Items/Actors to be transferred to an Actor's token.

Related issues #

Open questions The specific list style of the effects in the various html files could possibly be improved, but I just grabbed the styling from the SWADE game system.

I'm aware that trying to use active effects to modify the pools usually ends up with the fields becoming read-only, since their values have become overridden by the active effect - but then active effects shouldn't really be getting use for that sort of thing.

mrkwnzl commented 1 year ago

Has become a module instead