mrkwnzl / cyphersystem-foundryvtt

The Cypher System for Foundry VTT
Other
21 stars 14 forks source link

Leaving cost blank on combat/skill and rolling sets the pool to blank #336

Closed farling42 closed 11 months ago

farling42 commented 11 months ago

Describe the bug
With a combat or skill with a skill chosen but nothing entered into the cost, using the skill blanks out the Actor's pool current value field.

Expected behavior
The cost should be assumed to be 0, rather than using blank or NaN.

Setup

Additional context
In the all-in-one dialog, if you blank out the cost field, moving away from the field sets it to 0. This should probably happen in the Item editor too (but it would also need an extra check in the roll handling code to proper handle a blank cost).

mrkwnzl commented 11 months ago

Good catch! Will have a fix shortly.

mrkwnzl commented 11 months ago

Fixed in v2.10.2