mrlacey / MauiAppAccelerator

A Visual Studio extension to accelerate the creation of new .NET MAUI apps.
https://marketplace.visualstudio.com/items?itemName=MattLaceyLtd.MauiAppAccelerator
MIT License
352 stars 10 forks source link

Syntax Error. The type or namespace name 'Tasks' could not be found #40

Closed MiaJohnson closed 1 year ago

MiaJohnson commented 1 year ago

Describe the bug When creating a new project using ListDetail Page, MVVM Toolkit, and SQLLite it creates the templated ListViewModel using bad syntax on the OnRefreshing method.

To Reproduce Steps to reproduce the behavior:

  1. Visual Studio 2022 create new project
  2. Project Template Maui App Accelerator
  3. Add name & click create
  4. The "New .NET MAUI app (the name you called the project)" box shows.
  5. On Coding Style, select MVVM Toolkit
  6. On Pages, select "ListDetail"
  7. On Features, select Maui Community Toolkit & sqlite-net-pcl
  8. Click Create

Expected behavior When the ViewModel class template in a new project (using the above options) is created, that the private async Tasks OnRefreshing is created with private async Task OnRefreshing instead.

Screenshots Screenshot 2023-11-18 060154

Versions (please complete the following information):

Additional context I LOVE YOUR PROJECT! Thank you for creating this!

mrlacey commented 1 year ago

Thanks for reporting. Hot fix coming. But I first want to work out how this got through testing 🤔

mrlacey commented 1 year ago

v1.3.3 has just been released to the marketplace with this fix.

I don't know how this slipped through testing previously - sorry.

MiaJohnson commented 1 year ago

Oh my gosh! I didn't mean to make you work on the holidays. Thank you for the quick fix!

And thank you for building this. I've been playing with it for the last few days and it is AMAZING! Really impressive! Thank you so much for creating it and making it available to us.

I hope you have a great Thanksgiving. Thanks again! Mia

On Thu, Nov 23, 2023, 4:41 AM Matt Lacey @.***> wrote:

v1.3.3 has just been released to the marketplace with this fix.

I don't know how this slipped through testing previously - sorry.

— Reply to this email directly, view it on GitHub https://github.com/mrlacey/MauiAppAccelerator/issues/40#issuecomment-1824077094, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEO6TUUFZGXVRKXKVJJTBXTYF4K4TAVCNFSM6AAAAAA7Q44X26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRUGA3TOMBZGQ . You are receiving this because you authored the thread.Message ID: @.***>