Permit upgrade guacamole version

roumano commented 10 months ago

Hi @mrlesmithjr ,

actually as the binary compiled is already existing, this ansible role never updating the guacamole version

Description

Related Issue

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

mrlesmithjr commented 10 months ago

@roumano - I added you as a collaborator to this repo, so you don't have to wait on me, and your contributions are greatly appreciated.

roumano commented 9 months ago

Thanks i will accept my merge request and try to keep alive this repo , ...

where / how we can discuss for some specific issue/request ? ( on a issue ? )

like the 1.5.4 refuse to compile and my workarround is this :

- name: install | Configuring Guacamole Server Build # noqa no-changed-when
  ansible.builtin.command: ./configure --with-init-dir=/etc/init.d --disable-guacd
  args:
    chdir: "{{ guacamole_src_dir + '/guacamole-server-' + guacamole_version }}"
  become: true
  register: _guacamole_config_server_build
  when: not _guacamole_server_installed['stat']['exists'] or extract.changed
# Workarround for this bug in 1.5.4 : https://lists.apache.org/thread/h5zql3zdov0ngh8kp9r3yppcprq5z1jf
  environment:
    LDFLAGS: '-lrt'

but i'm not sure it's a good idea to enable to for all version and all OS

mrlesmithjr / ansible-guacamole