use Fully Qualified Collection Name (FQCN) ansible tasks

mrlesmithjr / ansible-mariadb-galera-cluster

MIT License

135 stars 113 forks source link

use Fully Qualified Collection Name (FQCN) ansible tasks #201

Closed roumano closed 7 months ago

roumano commented 7 months ago

Description

Use all tasks with FQCN name tasks

Related Issue

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

eRadical commented 7 months ago

Hi @roumano & thank you for this - it was on my mind also.

As this might be backward incompatible I need input from @mrlesmithjr & @elcomtik.

So - @mrlesmithjr & @elcomtik - thoughts?

elcomtik commented 7 months ago

I thought that we had already migrated to FQCN and newer Ansible. Ansible 2.9 is no longer supported so I'm definitely for making this breaking change.

A long time ago I did that for another role from mrlesmithjr (frr) and we bumped ansible to version 7. I would choose the current Ansible version, at time of writing version 9.

mrlesmithjr commented 7 months ago

You all make my work so much easier ;) In all seriousness, I truly appreciate all of you!

eRadical commented 7 months ago

My plan is first to merge this.

I'll make another PR where I'll change the min requirements - we must also bump up python to 3.10.

After this we need @mrlesmithjr to "release" a new version - either "v0.4.0" or go full with "v1" :)