search

mrlesmithjr / packer-builder

Packer Builder - Making Packer Building More Consumable
MIT License
11 stars 3 forks source link

Vsphere iso builder #67

Open bunchc opened 4 years ago

bunchc commented 4 years ago

Adds vsphere-iso builder support

mrlesmithjr commented 4 years ago

I am testing this in branch bunchc/vsphere-iso_builder. I fixed the Flake8 linting and then ran into the following error:

Template validation failed. Errors are shown below.

Errors validating build 'vsphere-iso'. 4 error(s) occurred:

* 'vcenter_server' is required
* 'username' is required
* 'password' is required
* 'host' or 'cluster' is required
bunchc commented 4 years ago

Ah, I removed those values for my environment. Would it make sense to supply generic values there and output something to the effect that they will need to be changed? Thinking some part of that, or leaving vsphere-iso off by default, and supplying a bit in the docs of how to enable it?

mrlesmithjr commented 4 years ago

Honestly I am good with either way. My original thought was to put some dummy values in there but could be just as easy as with commenting out along with some docs. Definitely need to get some docs around this thing ;)

bunchc commented 4 years ago

The other thought, was to put a secondary config file and a conditional that says "if vsphere-iso, get the additional values from here".

mrlesmithjr commented 4 years ago

To get this merged in, let's go ahead and either comment it out or enter generics. We can document this as well. I am about to start putting some documentation around this ASAP.