Closed 7840vz closed 1 year ago
I am not sure I understand your _info
comment. Would you rename the two metrics mentioned here to include _info
at the end?
I would recommend to do so, to comply with naming best practices. So metrics would become idrac_bios_version_info and idrac_machine_info. This is breaking change though, so up to you.
I think it's fine to fix it. I will rename them to idrac_bios_info
(having version in the name is redundant) and idrac_machine_info
.
Currently metadata metrics return NaN as value:
But as a common practice, value for such metrics should be always '1'
https://prometheus.io/docs/practices/naming/ https://www.robustperception.io/exposing-the-software-version-to-prometheus/