mrlhansen / idrac_exporter

Simple Redfish (iDRAC, iLO, XClarity) exporter for Prometheus
MIT License
133 stars 40 forks source link

Inventory metrics return NaN #8

Closed 7840vz closed 1 year ago

7840vz commented 1 year ago

Currently metadata metrics return NaN as value:

idrac_bios_version{version="2.11.2"} NaN
idrac_machine{manufacturer="Dell Inc.",model="PowerEdge R740",serial="xxxxx",sku="xxxx"} NaN

But as a common practice, value for such metrics should be always '1'

https://prometheus.io/docs/practices/naming/ https://www.robustperception.io/exposing-the-software-version-to-prometheus/

mrlhansen commented 1 year ago

I am not sure I understand your _info comment. Would you rename the two metrics mentioned here to include _info at the end?

7840vz commented 1 year ago

I would recommend to do so, to comply with naming best practices. So metrics would become idrac_bios_version_info and idrac_machine_info. This is breaking change though, so up to you.

mrlhansen commented 1 year ago

I think it's fine to fix it. I will rename them to idrac_bios_info (having version in the name is redundant) and idrac_machine_info.