mrlt8 / docker-wyze-bridge

WebRTC/RTSP/RTMP/LL-HLS bridge for Wyze cams in a docker container
GNU Affero General Public License v3.0
2.45k stars 151 forks source link

Unable to disable MQTT using MQTT_HOST: false #1232

Closed cmgenius closed 2 weeks ago

cmgenius commented 1 month ago

Using the HA addon, I am attempting to disable MQTT functionality. Setting MQTT_HOST to false as instructed in the documentation results in an error as pictured below. Is this a bug or am I doing something incorrectly?

Screenshot 2024-05-26 at 21 59 12
mrlt8 commented 1 month ago

I believe it might need to be a string:

MQTT_HOST: "false"

However, since we're pulling the mqtt setting from Home Assistant, it might still get ignored.

Will have to look into this.

mrlt8 commented 3 weeks ago

@cmgenius you should be able to disable MQTT by setting MQTT_DTOPIC to something other than homeassistant in the latest update.

jhansche commented 3 weeks ago

Minor clarification here: that doesn't disable mqtt, right? That just changes the discovery topic, to something that HA isn't listening to? And looking at the commit, it also now disables the auto discovery of the mqtt add-on host.

In other words, if you had previously changed your HA discovery topic to something other than the default, it also wouldn't auto-discover, unless you set the bridge dtopic to match? But now doing so means it also wouldn't auto discover the host, so you'll have to manually configure that as well?

I guess my point is that it seems to be catering to a default case, and for someone who has changed their HA discovery topic, it means they also have to configure the host explicitly as well. I think it would just be more clear to have an explicit setting for these

This way you don't have to assign double-meaning to either the host (disable) or the dtopic (homeassistant)

mrlt8 commented 3 weeks ago

hmm, I personally don't use HA so I wasn't aware that the discovery topic was configurable.

Will have to look into it again.

I really wish HA was more like Homebridge as the current config is getting extremely large!