search

mrlucas84 / embermediamanager

Automatically exported from code.google.com/p/embermediamanager
0 stars 0 forks source link

little fixes - no impact - cosmetic only #134

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
And me again

in clsGlobal Function GetResFromDimensions
....
If sinWidth >= 960 AndAlso sinHeight >= 500 Then Return "720"
If sinWidth >= 720 AndAlso sinHeight >= 500 Then Return "576" 
If sinWidth <= 960 AndAlso sinHeight >= 500 Then Return "540" 
If sinWidth < 640 Then Return "SD"
If sinWidth <= 960 AndAlso sinHeight <= 500 Then Return "480" 
....

should be ... for easy reading

If sinWidth >= 960 AndAlso sinHeight >= 500 Then Return "720"
If sinWidth >= 720 AndAlso sinHeight >= 500 Then Return "576" 
If sinWidth < 720 AndAlso sinHeight >= 500 Then Return "540" 
If sinWidth < 640 Then Return "SD"
If sinWidth < 960 AndAlso sinHeight < 500 Then Return "480"

Original issue reported on code.google.com by nfnovais@gmail.com on 8 Jun 2009 at 9:58

GoogleCodeExporter commented 9 years ago 
Hmmm not sure why I did that. I took your changes, then also tweaked 620 to be 
height
>= 600:

            If sinWidth >= 1600 AndAlso sinHeight >= 800 Then Return "1080"
            If sinWidth >= 1350 AndAlso sinHeight >= 750 Then Return "768"
            If sinWidth >= 960 AndAlso sinHeight >= 600 Then Return "720"
            If sinWidth >= 720 AndAlso sinHeight >= 500 Then Return "576"
            If sinWidth < 720 AndAlso sinHeight >= 500 Then Return "540"
            If sinWidth < 640 Then Return "SD"
            If sinWidth < 960 AndAlso sinHeight < 500 Then Return "480"

Original comment by jason.schnitzler on 9 Jun 2009 at 1:03

GoogleCodeExporter commented 9 years ago 
Just changed this again to be:

            If sinWidth >= 1600 AndAlso sinHeight >= 800 Then Return "1080"
            If sinWidth >= 1350 AndAlso sinHeight >= 750 Then Return "768"
            If sinWidth >= 960 AndAlso sinHeight >= 600 Then Return "720"
            If sinWidth >= 720 AndAlso sinHeight >= 500 Then Return "576"
            If sinWidth < 720 AndAlso sinHeight >= 500 Then Return "540"
            If sinWidth < 640 Then Return "SD"
            Return "480"

Original comment by jason.schnitzler on 9 Jun 2009 at 3:22

GoogleCodeExporter commented 9 years ago

Original comment by jason.schnitzler on 14 Jun 2009 at 8:57