Option to limit size of detected media (eg skip files which are smaller than a selectable filesize)

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Select a movie entry with a VIDEO_TS folder inside the movie's main folder
2. Open the movie's information
3. Navigate to frame extraction , set the number of thumbnails and Auto Generate

What is the expected output? What do you see instead?
Expected the specified number of thumbnails to be generated. Instead, the 
'extracting frame' 
progress dialog flashes up for a split second, and an empty extrathumbs folder 
is generated 
inside the VIDEO_TS folder, as opposed to inside the main movie folder as it 
should be.

Expected:

This Movie Name (2008)
   |
    - - -VIDEO_TS
    ----extrathumbs

Actual:

This Movie Name (2008)
   |
    - - -VIDEO_TS
                  |
                  ----extrathumbs

What version of the product are you using? On what operating system?

r263 x86, Win XP SP3

Please provide any additional information below.

This may be more than one defect in one:

a) The extrathumbs folder location for VIDEO_TS is one folder too deep
b) Extrathumbs auto-generation does not work (tried in mkv, avi, divx and other 
movies), but no 
log is reported
c) when entering a number of thumbs in the appropriate, pressing enter is 
mistakenly identified 
as an OK and closes the entire information window.

Original issue reported on code.google.com by roamer...@gmail.com on 9 Jun 2009 at 7:59

[GoogleCodeExporter]

Typo: "c) when entering a number of thumbs in the appropriate FIELD, pressing 
enter is mistakenly identified 
as an OK and closes the entire information window."

Original comment by roamer...@gmail.com on 9 Jun 2009 at 8:01

[GoogleCodeExporter]

a> I don't use VIDEO_TS folders so I just have to go based on docs and what I'm 
told,
and it's my understanding that for XBMC compatibility the files need to be 
inside the
VIDEO_TS folders and for YAMJ compatibility the files need to be inside the 
parent
folder. So, do you have "Use YAMJ compatible VIDEO_TS File Placement/Naming" 
enabled
and it's still doing this? Or, if you use XBMC, why do you want the extrathumbs
folder in the parent folder? The empty extrathumbs problem was already fixed in
SVN.... after attempting to generate thumbs it checks if the folder is empty. 
If it
is, it will automatically delete it.

b> I've already fixed this as well. Come to think of it, the directory placement
problem may have been an issue that I fixed for next release as well (I 
re-wrote a
lot of that code)

c> I'll fix that for next release.

Original comment by jason.schnitzler on 10 Jun 2009 at 12:40

• Changed state: Investigating

[GoogleCodeExporter]

Is this still an issue with r283?

Original comment by jason.schnitzler on 11 Jun 2009 at 12:37

[GoogleCodeExporter]

Yes. To add to it all, the extrathumbs checkbox column in the app's main view 
is now always empty for all 
movies, regardless of whether extrathumbs are actually present. Deleting the 
.emm database and rescanning is 
no use.

Original comment by roamer...@gmail.com on 11 Jun 2009 at 7:32

[GoogleCodeExporter]

This is with r282 btw. I do not have access to r283.

Original comment by roamer...@gmail.com on 11 Jun 2009 at 7:33

[GoogleCodeExporter]

oops sorry, I meant r282. lol

I've already fixed the empty extrathumbs column for the next release.

And again, to help figure things out, I need to ask:

So, do you have "Use YAMJ compatible VIDEO_TS File Placement/Naming" enabled
and it's still doing this? Or, if you use XBMC, why do you want the extrathumbs
folder in the parent folder? 

Original comment by jason.schnitzler on 11 Jun 2009 at 7:51

[GoogleCodeExporter]

OK as it happens I was wrong about the placement of extrathumbs for XBMC, you 
were right and it is indeed 
inside the VIDEO_TS folder.

As far as the rest goes, I'm having very little luck getting auto-generation to 
work still. Auto-pilot for 
thumbnails doesn't even seem to try. I'm guessing a lot of it has to do with 
the detection bug you fixed for the 
next release, so I'll let you know.

Original comment by roamer...@gmail.com on 11 Jun 2009 at 11:39

[GoogleCodeExporter]

send me an email at jason.schnitzler [at] gmail.com and I can send you a test 
build
to see if it's working with the new code..... but it won't be till later today. 
It's
almost 7 AM here and I haven't slept yet. lol I'm going to bed.

Original comment by jason.schnitzler on 11 Jun 2009 at 11:53

[GoogleCodeExporter]

Link to test build sent.

Original comment by jason.schnitzler on 11 Jun 2009 at 7:45

[GoogleCodeExporter]

I pinned down the problem, I think: 

Extrathumb generation fail;s on VIDEO_TS folders containing a DVD menu. Loading 
the movie in Frame 
Extraction shows that EMM, instead of picking up the main movie VOB, picks up 
the menu instead. 

Auto-Gen and Auto-pilot extrathumb generation still does nothing. No errors 
reported in log.

This is all based on the test version.

Original comment by roamer...@gmail.com on 12 Jun 2009 at 9:16

[GoogleCodeExporter]

You can see which file it will be using by single clicking on the movie in the 
movie
list and looking in the status bar. That will show the full path to the movie as
stored in the database. It should be using the first VOB in the folder. If you 
have
the "No Spoilers" option set then it checks if the movie is at least 5 minutes
long... if not, it skips it. I'm assuming that's what's happening here.

A possible fix for this would be to have a size limitation option.... so you 
could
enter a size limit of say, 400mb.... if a video file is less than 400mb it will 
skip
it and check for others. Maybe a second option for this would be to have a "Use
anyway if only file" for folder type sources so if it finds a movie that is 
smaller
than the limit you set, but can't find any other movie files in the folder, 
then it
would go ahead and use that anyway. Do you think that would work?

Original comment by jason.schnitzler on 12 Jun 2009 at 3:34

[GoogleCodeExporter]

I think it might. Short of DVD traversal intelligence to figure out which is 
the actual movie file, this might do the 
trick. The interesting part will be trying to figure out  a reasonable default 
minimum size.

Original comment by roamer...@gmail.com on 12 Jun 2009 at 3:40

[GoogleCodeExporter]

Note to self.... skip size checks for files containing stacking markers.

Original comment by jason.schnitzler on 14 Jun 2009 at 12:28

• Changed state: Accepted

[GoogleCodeExporter]

Just changing from defect to enhancement and updating the title to be more
descriptive of where this issue ended up. lol

Original comment by jason.schnitzler on 14 Jun 2009 at 1:32

• Changed title: Option to limit size of detected media (eg skip files which are smaller than a selectable filesize)
• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

Done for next release. Default to 300 MB, set to 0 to disable. Also, option to 
skip
file size check for stacked files.

Original comment by jason.schnitzler on 17 Jun 2009 at 12:13

• Changed state: Done

[GoogleCodeExporter]

Verified! Working OK. Thank you!

Original comment by nadas.bence@gmail.com on 24 Jun 2009 at 7:10

• Changed state: Verified