mrlucas84 / embermediamanager

Automatically exported from code.google.com/p/embermediamanager
0 stars 0 forks source link

Inconsistent naming convention - Media flags(tag) vs. Studio tags #177

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hi Jason,

At least on two places("edit window" and "settings - scraper data") EMM is
calling the media flags as studio tags. I am not really sure where is this
"studio tag" thing originated(I think somewhere to Aeon skin, where
previously media flags were store in the studio tag of the nfo), but a lot
of people use this wrongly on the forum.

I think the best naming convention would be "Media flags" for this, but at
least "Media tags" in worst case... :)

Also I understood there is a dicussion on removing media flagging from EMM,
as xbmc now natively support this. Could you please involve me to this
discussion? Was it in email or in one of the tickets?

Original issue reported on code.google.com by nadas.bence@gmail.com on 22 Jun 2009 at 1:59

GoogleCodeExporter commented 9 years ago

Original comment by nadas.bence@gmail.com on 22 Jun 2009 at 1:59

GoogleCodeExporter commented 9 years ago
This is actually correct. There are now 2 ways of flagging media info in the 
nfo, via
the studio tag (the old skin based flags) and via the fileinfo tags (for native 
XBMC
media flagging compatibility). So, you have an option to scan media info (which
creates the fileinfo tags).... and a secondary option to create studio tags 
based on
this fileinfo.

We decided just to leave media info scanning in Ember for now, as it should be
compatible with XBMC's native flagging now.

Original comment by jason.schnitzler on 22 Jun 2009 at 6:37

GoogleCodeExporter commented 9 years ago
Ahhhhh. I see. Sorry for the misunderstanding. In this case:

Would it be possible to remove the "studio tag" field and rename "Real studio" 
to
"Studio" in the edit window, if "Use Media Info Studio Tag" is unchecked in 
settings?

Also, for better understanding, could you please rename "Use Media Info Studio 
Tag"
to "Store Media Info in Studio Tag" in settings? 

Original comment by nadas.bence@gmail.com on 22 Jun 2009 at 9:06

GoogleCodeExporter commented 9 years ago
Done! Thanks!

Original comment by jason.schnitzler on 22 Jun 2009 at 9:24

GoogleCodeExporter commented 9 years ago
Excellent! Thank you Jason!

Verified.

Original comment by nadas.bence@gmail.com on 22 Jun 2009 at 9:35