mrlunchbox777 / basic-setup

basic box setup
MIT License
6 stars 3 forks source link

bug: 41 bug make basic setupgeneralrcsh exit gracefully #113

Closed mrlunchbox777 closed 4 months ago

mrlunchbox777 commented 4 months ago

Thanks for contributing!

Background

To pass the semanic-prs check, ensure you prefix your title with one of the .types in semanic.yml, followed by a :, e.g. feature: My PR

IssueWhat issue are you resolving with this PR? Please provide the number or link. _NOTE:_ If you don't have an issue for this work, please create one before creating this PR.

Response: #41

DescriptionPlease describe how this PR is addressing the issue and/or why it is being addressed this way.

Response: This PR fixes the bug by adding bash try/catches around possible failures, then logging and exiting with 0 in the catches

Steps to Reproduce and TestPlease give us a step-by-step guide to reproduce the bug. A link to the steps in the issue is enough.

Response:

  1. Delete the shared-scripts dir
  2. Open a new terminal that would run basic-setup.generalrc.sh as part of it's initialization
  3. It should have failed to open, but now should let you know it's failing to finish and why (it will take longer while trying to find shared-scripts)

Required Checkboxes

All of these checkboxes are required for PR's to be considered.

PR Checks

Code of Conduct

By submitting this PR, you agree to follow our Code of Conduct