To pass the semanic-prs check, ensure you prefix your title with one of the .types in semanic.yml, followed by a :, e.g. feature: My PR
IssueWhat issue are you resolving with this PR? Please provide the number or link. _NOTE:_ If you don't have an issue for this work, please create one before creating this PR.
Response: #41
DescriptionPlease describe how this PR is addressing the issue and/or why it is being addressed this way.
Response: This PR fixes the bug by adding bash try/catches around possible failures, then logging and exiting with 0 in the catches
Steps to Reproduce and TestPlease give us a step-by-step guide to reproduce the bug. A link to the steps in the issue is enough.
Response:
Delete the shared-scripts dir
Open a new terminal that would run basic-setup.generalrc.sh as part of it's initialization
It should have failed to open, but now should let you know it's failing to finish and why (it will take longer while trying to find shared-scripts)
Required Checkboxes
All of these checkboxes are required for PR's to be considered.
PR Checks
[x] I answered all of the background questions
[x] I have added sensible labels to the associated issue and this PR
[x] I have added/updated tests for all added/modified code, and all tests are passing
[x] I have added documentation, as appropriate, including CHANGELOG and version updates as needed
Code of Conduct
By submitting this PR, you agree to follow our Code of Conduct
[x] I agree to follow this project's Code of Conduct
Thanks for contributing!
Background
To pass the semanic-prs check, ensure you prefix your title with one of the
.types
in semanic.yml, followed by a:
, e.g.feature: My PR
Issue
What issue are you resolving with this PR? Please provide the number or link. _NOTE:_ If you don't have an issue for this work, please create one before creating this PR.Response: #41
Description
Please describe how this PR is addressing the issue and/or why it is being addressed this way.Response: This PR fixes the bug by adding bash try/catches around possible failures, then logging and exiting with 0 in the catches
Steps to Reproduce and Test
Please give us a step-by-step guide to reproduce the bug. A link to the steps in the issue is enough.Response:
Required Checkboxes
All of these checkboxes are required for PR's to be considered.
PR Checks
Code of Conduct
By submitting this PR, you agree to follow our Code of Conduct