mrlunchbox777 / basic-setup

basic box setup
MIT License
6 stars 3 forks source link

feature: Support windows nodes for create-node-shell #163

Open mrlunchbox777 opened 2 months ago

mrlunchbox777 commented 2 months ago

Contact Details

mrlunchbox777@gmail.com

Feature Description

Windows nodes should be supported by create-node-shell.

Why?

While they are less popular, windows nodes are a supported part of the k8s ecosystem, so management functions like create-node-shell should support them.

What should happen?

There are several parts in the create-node-shell function that assume it targeting a linux node, these should be abstracted out and support both linux and windows.

Covers this TODO, this TODO, and this TODO.

Steps to Test

  1. Target a linux and windows node with create-node-shell, it should create the node-shell pod and execute powershell/cmd (preferentially in that order) interactively on it

Code of Conduct