mrlunchbox777 / basic-setup

basic box setup
MIT License
6 stars 3 forks source link

feature: 180 feature move more scripts to golang #191

Open mrlunchbox777 opened 3 weeks ago

mrlunchbox777 commented 3 weeks ago

Thanks for contributing!

Background

To pass the semanic-prs check, ensure you prefix your title with one of the .types in semanic.yml, followed by a :, e.g. feature: My PR

IssueWhat issue are you resolving with this PR? Please provide the number or link. _NOTE:_ If you don't have an issue for this work, please create one before creating this PR.

Response: #180

DescriptionPlease describe how this PR is addressing the issue and/or why it is being addressed this way.

Response: This PR updates pipes and checks for CHANGELOG and version bumps as well as getting non-test coverage up to 100%

Steps to Reproduce and TestPlease give us a step-by-step guide to reproduce the bug. A link to the steps in the issue is enough.

Response:

  1. All of the workflows should pass
  2. make coverage should show 100% on everything except fake factory
  3. Creating a new test pr with changes, but not updating version should fail the version check
  4. Creating a new test pr with changes, but not updating CHANGELOG should fail the CHANGELOG check

Required Checkboxes

All of these checkboxes are required for PR's to be considered.

PR Checks

Code of Conduct

By submitting this PR, you agree to follow our Code of Conduct

github-actions[bot] commented 2 weeks ago

Merging this branch changes the coverage (1 decrease, 3 increase)

Impacted Packages Coverage Δ :robot:
github.com/mrlunchbox777/basic-setup/bsctl 0.00% (ø)
github.com/mrlunchbox777/basic-setup/bsctl/cmd 100.00% (+2.78%) :thumbsup:
github.com/mrlunchbox777/basic-setup/bsctl/cmd/basic_setup 100.00% (+22.22%) :star2:
github.com/mrlunchbox777/basic-setup/bsctl/static 100.00% (ø)
github.com/mrlunchbox777/basic-setup/bsctl/util 100.00% (+92.31%) :star2:
github.com/mrlunchbox777/basic-setup/bsctl/util/k8s 100.00% (ø)
github.com/mrlunchbox777/basic-setup/bsctl/util/test 14.71% (-8.70%) :thumbsdown:

Coverage by file ### Changed files (no unit tests) | Changed File | Coverage Δ | Total | Covered | Missed | :robot: | |--------------|------------|-------|---------|--------|---------| | github.com/mrlunchbox777/basic-setup/bsctl/cmd/basic_setup/add_general_rc.go | 100.00% (**+50.00%**) | 5 (+1) | 5 (+3) | 0 (-2) | :star2: | | github.com/mrlunchbox777/basic-setup/bsctl/cmd/basic_setup/root.go | 100.00% (ø) | 6 (+1) | 6 (+1) | 0 | | | github.com/mrlunchbox777/basic-setup/bsctl/cmd/cmd.go | 100.00% (ø) | 19 | 19 | 0 | | | github.com/mrlunchbox777/basic-setup/bsctl/cmd/completion.go | 100.00% (ø) | 10 (+1) | 10 (+1) | 0 | | | github.com/mrlunchbox777/basic-setup/bsctl/cmd/version.go | 100.00% (**+12.50%**) | 9 (+1) | 9 (+2) | 0 (-1) | :tada: | | github.com/mrlunchbox777/basic-setup/bsctl/main.go | 0.00% (ø) | 27 (+1) | 0 | 27 (+1) | | | github.com/mrlunchbox777/basic-setup/bsctl/static/constants.go | 100.00% (ø) | 11 (+2) | 11 (+2) | 0 | | | github.com/mrlunchbox777/basic-setup/bsctl/util/factory.go | 100.00% (**+92.31%**) | 15 (+2) | 15 (+14) | 0 (-12) | :star2: | | github.com/mrlunchbox777/basic-setup/bsctl/util/k8s/io_streams.go | 100.00% (**+100.00%**) | 4 (+4) | 4 (+4) | 0 | :star2: | | github.com/mrlunchbox777/basic-setup/bsctl/util/k8s/io_streams_and_stores.go | 100.00% (**+100.00%**) | 6 (+6) | 6 (+6) | 0 | :star2: | | github.com/mrlunchbox777/basic-setup/bsctl/util/k8s/io_streams_getter.go | 100.00% (**+100.00%**) | 12 (+12) | 12 (+12) | 0 | :star2: | | github.com/mrlunchbox777/basic-setup/bsctl/util/k8s/io_streams_store.go | 100.00% (**+100.00%**) | 1 (+1) | 1 (+1) | 0 | :star2: | | github.com/mrlunchbox777/basic-setup/bsctl/util/k8s/io_streams_tees.go | 100.00% (**+100.00%**) | 28 (+28) | 28 (+28) | 0 | :star2: | | github.com/mrlunchbox777/basic-setup/bsctl/util/test/fake_factory.go | 14.71% (**-8.70%**) | 102 (+8) | 15 (-7) | 87 (+15) | :thumbsdown: | _Please note that the "Total", "Covered", and "Missed" counts above refer to ***code statements*** instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code._ ### Changed unit test files - github.com/mrlunchbox777/basic-setup/bsctl/cmd/basic_setup/add_general_rc_test.go - github.com/mrlunchbox777/basic-setup/bsctl/cmd/basic_setup/root_test.go - github.com/mrlunchbox777/basic-setup/bsctl/cmd/cmd_test.go - github.com/mrlunchbox777/basic-setup/bsctl/cmd/completion_test.go - github.com/mrlunchbox777/basic-setup/bsctl/cmd/version_test.go - github.com/mrlunchbox777/basic-setup/bsctl/static/constants_test.go - github.com/mrlunchbox777/basic-setup/bsctl/util/factory_test.go - github.com/mrlunchbox777/basic-setup/bsctl/util/k8s/io_streams_and_stores_test.go - github.com/mrlunchbox777/basic-setup/bsctl/util/k8s/io_streams_getter_test.go - github.com/mrlunchbox777/basic-setup/bsctl/util/k8s/io_streams_store_test.go - github.com/mrlunchbox777/basic-setup/bsctl/util/k8s/io_streams_tees_test.go - github.com/mrlunchbox777/basic-setup/bsctl/util/k8s/io_streams_test.go